Conversation
Now needed for sid for some reason
…-sid Fix Sid dependencies and autopkgtest
…o master-resync
…roject/ola into master-resync
… master-resync
…/ola into master-resync
…n/ola into master-resync
…nto fix-tagset-compile
DaAwesomeP
left a comment
DaAwesomeP
left a comment
There was a problem hiding this comment.
I haven't been keeping up well enough with the PRs to different branches to really review this. I don't remember where the ResponderHelper.h or ResponderTagSet.h changes came from (or is this a new fix not a resync?).
Given (in this case it's so tiny) it can also be reviewed as a standalone thing.
I don't really understand how that got in, as it's not in any of the commits for this PR, so I guess it's part of a merge. However as per It needs to come out anyway, I messed up a commit elsewhere and committed more than I intended, which has now been merged to master unfortunately.
Yeah, as I mentioned in the description:
This is to fix (some) of your issues reported here: I suspect the rest are with Forky which we're not testing yet. |
DaAwesomeP
left a comment
DaAwesomeP
left a comment
There was a problem hiding this comment.
OK, sounds like it is good to go!
|
|
||
| #include <ola/Logging.h> | ||
| #include <ola/strings/Utils.h> | ||
| #include <stdint.h> |
There was a problem hiding this comment.
Is there a specific reason to use the C header stdint.h instead of the C++ header cstdint ?
3 participants
Also fix tagset compile